-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Test for pd.to_sql column error if data contains -np.inf #34493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for pd.to_sql column error if data contains -np.inf #34493
Conversation
Hey everyone - checking in in case there's anything I can do to keep this PR moving forward! |
Looks like there is a merge conflict and there are some CI failures in the Travis build |
@mroeschke Ok, I've looked into that now. It seems that the new test is failing:
But when I run Either way, what's the best way to proceed on this PR? Should I try to fix the problem in this PR (happy to carry on but I'll need some help on where to start debugging - not sure what to try right now) or mark the test as xfail? |
Looks like this issue isn't fully solved for MySQL based on the test failures. If you would like to solve this issue for MySQL, that'd be great. It might need to be handled in Otherwise, we would also xfail the test for MySQL and leave the original issue open. |
Looks ready to go - happy to work on any improvements, though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment otherwise LGTM
Thanks @arw2019. Nice PR as always |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff