-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Raise ValueError for non numerical join columns in merge_asof #34488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
660d2f5
cafedcc
fa1d909
34a5633
783bc60
e086864
a4001c6
aaa3480
ec3147e
129eb77
4680833
fb55c9f
72fb8b4
0103974
4cc8bdc
a6048a6
cdaa8ef
47e211c
3129353
0242f47
ef47721
109c824
3a66f05
da377c7
c0ce857
2c164c5
a00eb9c
f62a873
4782233
6ebb7a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1730,6 +1730,12 @@ def flip(xs) -> np.ndarray: | |
) | ||
tolerance = self.tolerance | ||
|
||
if is_object_dtype(right_values): | ||
phofl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
raise ValueError("Right input is not from numerical dtype") | ||
|
||
if is_object_dtype(left_values.dtype): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be loosened to include other non-numeric dtypes for which this should raise? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There exist tests for Timedelta and Datetime DataFrames, so this is expected to work I think?. Is there anything you would like to exclude? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You might be right, was just curious if this was indeed capturing all the "non-numeric" cases There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I hope so |
||
raise ValueError("Left input is not from numerical dtype") | ||
phofl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# we require sortedness and non-null values in the join keys | ||
if not Index(left_values).is_monotonic: | ||
side = "left" | ||
|
Uh oh!
There was an error while loading. Please reload this page.