ENH: mul(Tick, float); simplify to_offset #34486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 31, 2020
| @@ -743,6 +747,25 @@ cdef class Tick(SingleConstructorOffset): | |||
| "Tick offset with `normalize=True` are not allowed." | |||
| ) | |||
|
|
|||
| # FIXME: Without making this cpdef, we get AttributeError when calling | |||
| # from __mul__ | |||
| cpdef Tick _next_higher_resolution(Tick self): | |||
There was a problem hiding this comment.
wouldn't this be better as a module level routine?
There was a problem hiding this comment.
i dont think so. it uses self.n, so really makes sense as a method
| @@ -3563,6 +3601,9 @@ cpdef to_offset(freq): | |||
| >>> to_offset(Hour()) | |||
| <Hour> | |||
| """ | |||
| # TODO: avoid runtime imports | |||
There was a problem hiding this comment.
really really prefer absolute imports
There was a problem hiding this comment.
sure. im more concerned about getting rid of the runtime imports
| @@ -3598,15 +3641,19 @@ cpdef to_offset(freq): | |||
| if not stride: | |||
| stride = 1 | |||
|
|
|||
There was a problem hiding this comment.
can you give some comments on what is being done here
jreback
requested changes
May 31, 2020
| assert isinstance(result, Micro) | ||
|
|
||
| # Case where we bump up to the next type | ||
| result = off * 1.25 |
There was a problem hiding this comment.
was this buggy before? need a whatsnew note if so
There was a problem hiding this comment.
ATM it raises TypeError for any float, will add whatsnew
|
kk if u can rebase |
|
rebased+green |
jreback
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis will let us remove Resolution.get_stride_from_decimal