-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: merge_asof should be treated as a left join #34484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
49d1c23
BUG: take always left index in merge_asof
phofl 742a5d9
Add whatsnew entry
phofl 6736bfa
Merge branch 'master' of https://github.com/pandas-dev/pandas into 33463
phofl 81d736f
Merge master and move whats new
phofl 4b9336c
Fix pep 8 issues
phofl 6e3553f
Move asof case to get_join_info
phofl bfa5d26
Run black pandas
phofl ab079df
Change index and method signature
phofl 2b24385
Merge branch 'master' of https://github.com/pandas-dev/pandas into 33463
phofl 04deda9
Merge branch 'master' of https://github.com/pandas-dev/pandas into 33463
phofl 3add9da
Fix pre commit
phofl 0112c4d
Merge branch 'master' of https://github.com/pandas-dev/pandas into 33463
phofl a704eee
Move whatsnew
phofl 43b240d
Merge branch 'master' of https://github.com/pandas-dev/pandas into 33463
phofl 702a0ea
Merge branch 'master' of https://github.com/pandas-dev/pandas into 33463
phofl f3d2e0f
Add comment
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a comment here explaining why we're doing
how="left"
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done