Skip to content

Fix MultiIndex .loc "Too Many Indexers" with None as return value #34450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 3, 2020
Merged

Fix MultiIndex .loc "Too Many Indexers" with None as return value #34450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0c02a7f
BUG: Fixes Issue #34318
pedrooa May 29, 2020
2db8090
testing integration
pedrooa Jun 1, 2020
537fc45
BUG: change Exception to IndexingError
pedrooa Jun 1, 2020
8a540ff
BUG: more tests and whats new note added
pedrooa Jun 2, 2020
6cab469
BUG: fix code formatting
pedrooa Jun 2, 2020
25800c6
new file for multiindex tests
pedrooa Jun 2, 2020
0bc5844
relocating multiindex test
pedrooa Jun 2, 2020
553a879
Fix code formatting
pedrooa Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions pandas/core/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,9 +766,11 @@ def _getitem_lowerdim(self, tup: Tuple):
# ...but iloc should handle the tuple as simple integer-location
# instead of checking it as multiindex representation (GH 13797)
if isinstance(ax0, ABCMultiIndex) and self.name != "iloc":
result = self._handle_lowerdim_multi_index_axis0(tup)
if result is not None:
try:
result = self._handle_lowerdim_multi_index_axis0(tup)
return result
except Exception:
pass

if len(tup) > self.ndim:
raise IndexingError("Too many indexers. handle elsewhere")
Expand Down Expand Up @@ -816,9 +818,11 @@ def _getitem_nested_tuple(self, tup: Tuple):
if self.name != "loc":
# This should never be reached, but lets be explicit about it
raise ValueError("Too many indices")
result = self._handle_lowerdim_multi_index_axis0(tup)
if result is not None:
try:
result = self._handle_lowerdim_multi_index_axis0(tup)
return result
except Exception:
pass

# this is a series with a multi-index specified a tuple of
# selectors
Expand Down Expand Up @@ -1065,7 +1069,7 @@ def _handle_lowerdim_multi_index_axis0(self, tup: Tuple):
if len(tup) <= self.obj.index.nlevels and len(tup) > self.ndim:
raise ek

return None
raise Exception("No label returned")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not already raise a KeyError a few lines up?


def _getitem_axis(self, key, axis: int):
key = item_from_zerodim(key)
Expand Down
11 changes: 11 additions & 0 deletions pandas/tests/series/indexing/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,17 @@ def test_setitem_slice_into_readonly_backing_data():
assert not array.any()


def test_access_none_value_in_multiindex():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make a new file in this dir: test_multiindex.py

we have the MI tests elsewhere so ok starting a new file here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I copy all the imports from test_indexing.py?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need whatever imports make flake happy :->

# GH34318: test that you can access a None value using .loc through a Multiindex

expected = None
result = pd.Series([None], pd.MultiIndex.from_arrays([["Level1"], ["Level2"]])).loc[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you write this in a more readable way

s = Series(......)
result = s.loc....
assert result is None

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add all the examples here as well: #34318 (comment)

("Level1", "Level2")
]

assert expected == result


"""
miscellaneous methods
"""
Expand Down