BUG: ensure_timedelta64ns overflows #34448
Conversation
| @@ -80,6 +86,12 @@ def test_ensure_datetime64ns_bigendian(): | |||
| tm.assert_numpy_array_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_ensure_timedelta64ns_overflows(): | |||
| arr = np.arange(10).astype("m8[Y]") * 100 | |||
| with pytest.raises(OutOfBoundsDatetime, match="Out of bounds"): | |||
There was a problem hiding this comment.
this is the wrong type that is raises for this dtypes
There was a problem hiding this comment.
yah, im not too bothered by the exception type, but the exception message is going to have a datetime string in it that wont be helpful. giving this some thought
|
@WillAyd any thoughts on what to do here? IIRC you implemented the C conversion functions for td64 |
|
So IIUC you are concerned about the value shown in the error message right? I did implement the time delta->ISO string methods which could use here, though not sure if necessary |
|
updated to give a timedelta-specific exception message |
pandas/_libs/tslibs/conversion.pyx
Outdated
| bad_val = tdmax | ||
|
|
||
| unit_str = arr.dtype.str.split("[")[-1][:-1] | ||
| raise OutOfBoundsDatetime( |
There was a problem hiding this comment.
can we just create OutOfBoundsTimedelta
There was a problem hiding this comment.
i think if we create an OOBTimedelta exception would be ok ith this change
|
updated with requested new exception class |
|
updated+green |
pandas/_libs/tslibs/conversion.pyx
Outdated
| else: | ||
| bad_val = tdmax | ||
|
|
||
| unit_str = arr.dtype.str.split("[")[-1][:-1] |
There was a problem hiding this comment.
this seems fragile, can you just report it entirely:
In [39]: np.dtype('m8[ms]').name
Out[39]: 'timedelta64[ms]'
|
ping |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff