Skip to content

TST: additional regression cases for slicing blockwise op (GH34421) #34434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020

Conversation

jorisvandenbossche
Copy link
Member

Adding the other case from #34367 to the test as well (although also fixed by the PR, it was failing with a different error originally, so might be worth it to add as test case as well).

cc @jbrockmendel

@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone May 28, 2020
@jreback jreback added Testing pandas testing functions or related to the test suite Numeric Operations Arithmetic, Comparison, and Logical operations labels May 28, 2020
@jreback jreback merged commit 1e0335f into pandas-dev:master May 28, 2020
@jreback
Copy link
Contributor

jreback commented May 28, 2020

thanks @jorisvandenbossche

@jbrockmendel
Copy link
Member

nice, thanks. this has me wondering if we can use hypothesis to cover the space of block layouts

@jorisvandenbossche jorisvandenbossche deleted the test-arithm branch May 29, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants