TST closes #28980 Certain comparison operations misbehaving for period dtype #34417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good, can you modify the description with "closes" in front of the issue number so that it'll be closed automatically when this is merged? |
OlivierLuG
changed the title
@OlivierLuG I meant the description of the PR (where you have the bulleted list) rather than the PR title |
|
Hello, If you think this is correct, I can pull a new request to close #28981, which test about the same tests ? |
|
thanks |
| @@ -1522,3 +1522,11 @@ def test_pi_sub_period_nat(self): | |||
| exp = pd.TimedeltaIndex([np.nan, np.nan, np.nan, np.nan], name="idx") | |||
| tm.assert_index_equal(idx - pd.Period("NaT", freq="M"), exp) | |||
| tm.assert_index_equal(pd.Period("NaT", freq="M") - idx, exp) | |||
|
|
|||
| @pytest.mark.parametrize("scalars", ["a", False, 1, 1.0, None]) | |||
| def test_comparison_operations(self, scalars): | |||
There was a problem hiding this comment.
why not use the box_with_array fixture?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added test to compare
pd.Series([...], dtype="period[A-DEC]")to dtypestr,bool,int,floatandNone.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff