Skip to content

REF: is_subperiod, is_superperiod out of libfreqs #34387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2020

Conversation

jbrockmendel
Copy link
Member

When we first moved these functions from tseries.frequencies to libfrequencies a couple years ago there was a question of it was really necessary, and the answer is now an unambiguous "no"

@jreback jreback added the Frequency DateOffsets label May 26, 2020
@jreback jreback added this to the 1.1 milestone May 26, 2020
@jreback
Copy link
Contributor

jreback commented May 26, 2020

seems fine, yeah if its not needed in cython then better in python space.

@jbrockmendel
Copy link
Member Author

green

@jreback jreback merged commit 0859bac into pandas-dev:master May 26, 2020
@jbrockmendel jbrockmendel deleted the ref-libfreqs-less branch May 26, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frequency DateOffsets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants