CLN: remove _combine_series_frame #34374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm ping on green. |
topper-123
reviewed
May 26, 2020
| @@ -223,7 +223,7 @@ def evaluate(op, a, b, use_numexpr: bool = True): | |||
| use_numexpr : bool, default True | |||
| Whether to try to use numexpr. | |||
| """ | |||
| op_str = _op_str_mapping.get(op, None) | |||
| op_str = _op_str_mapping[op] | |||
| if op_str is not None: | |||
There was a problem hiding this comment.
Isnt this always true, so you can drop the if statement now?
There was a problem hiding this comment.
it is not always true, some entries in _op_str_mapping give None
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this we can consolidate some dispatch_to_series calls, saving that for a separate step for clarity of exposition.