CLN Replace old string formatting syntax with f-strings #29547: 2 files w… #34370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2 files were fixed
dsaxton
reviewed
May 25, 2020
pandas/_libs/tslibs/timedeltas.pyx
Outdated
| @@ -584,7 +584,7 @@ cdef inline int64_t parse_iso_format_string(str ts) except? -1: | |||
| bint have_dot = 0, have_value = 0, neg = 0 | |||
| list number = [], unit = [] | |||
|
|
|||
| err_msg = "Invalid ISO 8601 Duration format - {}".format(ts) | |||
| err_msg = "Invalid ISO 8601 Duration format - {ts}" | |||
There was a problem hiding this comment.
How dumb I am ! I will propose a new (valid) PR tomorow.
Thank for the reply
| @@ -194,7 +194,7 @@ def integer_op_not_supported(obj): | |||
| "Addition/subtraction of integers and integer-arrays with {cls} is " | |||
| "no longer supported. Instead of adding/subtracting `n`, " | |||
| "use `n * obj.freq`" | |||
| ).format(cls=cls) | |||
| ) | |||
OlivierLuG
changed the title
|
Hello, I’ve fixed the 2 issues. All test were passed successfully. |
|
thanks @OlivierLuG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i'm new to github / opensource. Let me know if I'm doing things correctly
pandas/_libs/tslibs/timedeltas.pyx
pandas/_libs/tslibs/timestamps.pyx
Replace old string formatting syntax with f-strings #29547
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff