TST: category isin on frame #34363
Merged
TST: category isin on frame #34363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
May 25, 2020
Comment on lines
199
to
200
| expected1 = DataFrame({"a": [True, True, True], "b": [False, False, False]}) | ||
| expected2 = DataFrame({"a": [True, True, True], "b": [False, False, False]}) |
There was a problem hiding this comment.
What's the difference between these two? Can you just use one, call it expected, and use it for both assertions?
jreback
added
Algos
jreback
requested changes
May 25, 2020
dsaxton
reviewed
May 28, 2020
| "category", | ||
| [ | ||
| pd.DataFrame({"a": [1, 2, 3]}, dtype="category"), | ||
| pd.Series([1, 2, 3]).astype("category"), |
There was a problem hiding this comment.
You can set this using dtype="category" instead of astyping
| @@ -189,3 +189,18 @@ def test_isin_empty_datetimelike(self): | |||
| tm.assert_frame_equal(result, expected) | |||
| result = df1_td.isin(df3) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "category", | |||
There was a problem hiding this comment.
Rather than calling this argument "category" something like "values" or "other" (for example) seems more appropriate
| ) | ||
| def test_isin_category_frame(self, category): | ||
| # GH#34256 | ||
| df = pd.DataFrame.from_dict({"a": [1, 2, 3], "b": [4, 5, 6]}) |
There was a problem hiding this comment.
I don't think we need from_dict here
|
@vampypandya can you update with the requested changes? |
jreback
approved these changes
Jul 10, 2020
|
thanks @vampypandya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff