-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix render as column name in to_excel #34335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 7 commits into
pandas-dev:master
from
phofl:34331_render_column_name_raises_error_in_to_excel
May 26, 2020
Merged
BUG: Fix render as column name in to_excel #34335
jreback
merged 7 commits into
pandas-dev:master
from
phofl:34331_render_column_name_raises_error_in_to_excel
May 26, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@phofl You can add a bug fix whatsnew note under the I/O section in pandas/doc/source/whatsnew/v1.1.0.rst |
dsaxton
reviewed
May 24, 2020
Àdded the whats new entry |
jreback
requested changes
May 25, 2020
jreback
reviewed
May 25, 2020
jreback
reviewed
May 26, 2020
jreback
approved these changes
May 26, 2020
thanks @phofl very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Should I add a whats new enty? Under which section?
https://github.com/phofl/pandas/blob/34331_render_column_name_raises_error_in_to_excel/pandas/io/formats/excel.py#L389
The previous code checked if the
df
had a attributerender
. This check was True, if there was aDataFrame
given as input with a columnrender
. I think that this check should only be True if aStyler
object is given, so I added anisinstace
check forStyler
.Does the
Styler
object always an attributerender
? If not, we would run into problems, if we get aStyler
object with a column namedrender
but without therender
attribute. If aStyler
object has always an attributerender
, we could delete thehasattr
check.Edit: I changed the check to
not isinstance(df, DataFrame)
to avoid the jinja issues.