BUG: xticks unnecessarily rotated

[MarcoGorelli]

• closes xticks unnecessarily rotated #29460
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

On master, xticklabels are rotated if

            not self._use_dynamic_x()
            and data.index.is_all_dates
            and not self.subplots
            or (self.subplots and self.sharex)

There's a comment saying

        if condition:
            # irregular TS rotated 30 deg. by default
            # probably a better place to check / set this.
            if not self._rot_set:
                self.rot = 30

, and it seems that the intention was to rotate ticklabels if there's an irregular timeseries.

With the condition as it is written, they will also be rotated if the following is true:

(self.subplots and self.sharex)

I don't see why that should warrant rotating the ticklabels, so I'd like to suggest that there was a bracketing error.

Also, the condition data.index.is_all_dates is (as far as I can tell) only relevant if use_index=True, so I've changed that.

Here's what the OP's plot looks like with these changes:

Here's what it looks like on master:

Irregular time series still have their ticklabels rotated:

Regular time series' ticklabels don't rotate:

(unless you pass xcompat=True, but that's unaffected by this change)

[charlesdong1991]

very nice!

only one nitpick, but could also choose to ignore since it doesn't really matter

[charlesdong1991]

not a big issue, i would prefer to shuffle the tests a bit to put similar tests together because it's quite clear there are three sub-groups to test, I would prefer something like this:

        # regular time series
        x = to_datetime(["2020-05-01", "2020-05-02", "2020-05-03"])
        df = DataFrame({"x": x, "y": [1, 2, 3]})
        axes = df.plot(x="x", y="y")
        self._check_ticks_props(axes, xrot=0)

        # irregular time series
        x = to_datetime(["2020-05-01", "2020-05-02", "2020-05-04"])
        df = DataFrame({"x": x, "y": [1, 2, 3]})
        axes = df.plot(x="x", y="y")
        self._check_ticks_props(axes, xrot=30)

        # use timeseries index or not
        axes = df.set_index("x").plot(y="y", use_index=True)
        self._check_ticks_props(axes, xrot=30)
        axes = df.set_index("x").plot(y="y", use_index=False)
        self._check_ticks_props(axes, xrot=0)

        # separate subplots
        axes = df.plot(x="x", y="y", subplots=True, sharex=True)
        self._check_ticks_props(axes, xrot=30)
        axes = df.plot(x="x", y="y", subplots=True, sharex=False)
        self._check_ticks_props(axes, xrot=0)

or even to split them into different tests, and parametrize the parameter.

[MarcoGorelli]

That's a good suggestion, thanks!

[jreback]

can u merge master and ping on green

[MarcoGorelli]

@jreback ping

[charlesdong1991]

i am very sorry to be a badass to block your PR, just come across it, can you change Dataframe to DataFrame? 😅

[MarcoGorelli]

😆 good catch, thanks!

[simonjayhawkins]

@MarcoGorelli can you move release note to 1.2

[jreback]

tiny comment, otherwsie lgtm

[jreback]

use subplots=True (in double-backticks) so its easily readable

[jreback]

@charlesdong1991 @jorisvandenbossche @TomAugspurger if comments.

[TomAugspurger]

Nothing here.

…

On Wed, Aug 12, 2020 at 10:55 AM Jeff Reback ***@***.***> wrote: @charlesdong1991 <https://github.com/charlesdong1991> @jorisvandenbossche <https://github.com/jorisvandenbossche> @TomAugspurger <https://github.com/TomAugspurger> if comments. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#34334 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKAOIXRYE56GRJHYMFDT6LSAK3QZANCNFSM4NIMUDHA> .

[charlesdong1991]

lgtm

[jbrockmendel]

@MarcoGorelli can you rebase. looks like this was about ready

[jreback]

thanks for this @MarcoGorelli nice! (and good to add the testing like you did).