CI: Numpy compat #34321
Merged
CI: Numpy compat #34321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really follow the issue / fix here: Did the changes go like this?
Or am I misunderstanding? |
For 1.17.4 I see -> hence I thought the easiest fix is just to require numpy 1.18 ? Or am i missing something? Ill also will need to update the test changes made in https://github.com/pandas-dev/pandas/pull/32510/files @TomAugspurger - mind doing the azp run command -> I don't have permissions. |
|
@alimcmaster1 restarted the failing job on travis (was a network error i think). but this looks good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely related to: #32510.
Seems doc builds have started using:
numpy 1.17.5 py38h95a1406_0 conda-forge
https://github.com/pandas-dev/pandas/pull/34317/checks?check_run_id=700337761
(Previous pipelines where using 1.18)
In numpy 1.17.5 BitGenerator path is:
np.random.bit_generator.BitGeneratorIn numpy 1.18.0 path is
np.random.BitGenerator