CLN: consolidate arrow roundtrip tests for nullable dtypes in base masked tests #34308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently splitted the test_boolean and test_integer in multiple files in each a directory, but I think a next step can be to deduplicate some of the common tests for the different nullable/masked dtypes.
Certainly given that we are going to add float tests as well (cfr #34307)
Starting here with the arrow-compat/roundtrip tests for both integer/boolean.
I didn't yet write a full blown conftest.py and just defined a
data
fixture inline, since here it's just a single file. But if adding more later, we probably want to move this to aconftest.py
(or a base test class), although this duplicates a bit thetests/arrays/integer/conftest.py
andtests/arrays/boolean/conftest.py
cc @dsaxton @jbrockmendel