Skip to content

CLN: consolidate arrow roundtrip tests for nullable dtypes in base masked tests #34308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

We recently splitted the test_boolean and test_integer in multiple files in each a directory, but I think a next step can be to deduplicate some of the common tests for the different nullable/masked dtypes.
Certainly given that we are going to add float tests as well (cfr #34307)

Starting here with the arrow-compat/roundtrip tests for both integer/boolean.

I didn't yet write a full blown conftest.py and just defined a data fixture inline, since here it's just a single file. But if adding more later, we probably want to move this to a conftest.py (or a base test class), although this duplicates a bit the tests/arrays/integer/conftest.py and tests/arrays/boolean/conftest.py

cc @dsaxton @jbrockmendel

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Clean NA - MaskedArrays Related to pd.NA and nullable extension arrays labels May 22, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone May 22, 2020
@jbrockmendel
Copy link
Member

seems reasonable

@jbrockmendel
Copy link
Member

if there are follow-ups you have in mind but are liable to not get to right away, can you either add TODO comments or open issue(s)

@jreback jreback merged commit b3ab167 into pandas-dev:master May 22, 2020
@jreback
Copy link
Contributor

jreback commented May 22, 2020

thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the masked-tests-cleanup-arrow branch May 23, 2020 06:47
@jorisvandenbossche
Copy link
Member Author

if there are follow-ups you have in mind but are liable to not get to right away, can you either add TODO comments or open issue(s)

None specific, but just in general any test in integer/ and boolean/ that is almost identical for both directories and could be shared, can be consolidated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean NA - MaskedArrays Related to pd.NA and nullable extension arrays Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants