Skip to content

REF: make operate_blockwise into a BlockManager method #34281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2020
Merged

REF: make operate_blockwise into a BlockManager method #34281

merged 2 commits into from
May 22, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented May 20, 2020 •
edited
Loading

More appropriate abstraction.

@jbrockmendel jbrockmendel added the Refactor Internal refactoring of code label May 21, 2020
jorisvandenbossche
jorisvandenbossche reviewed May 22, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed a better place to put it. Just a remark on the naming of the method.

@jbrockmendel
Copy link
Member Author

CI fail looks unrelated

@jreback jreback added this to the 1.1 milestone May 22, 2020
@jreback jreback merged commit e06e381 into pandas-dev:master May 22, 2020
@jreback
Copy link
Contributor

jreback commented May 22, 2020

yep, much nicer!

@jbrockmendel jbrockmendel deleted the ref-ops-alignment branch May 22, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @jorisvandenbossche