Fix .isin Considers "1" and 1 equal #34267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mparing a int df with a string value on isin comparation
WillAyd
requested changes
May 20, 2020
jreback
requested changes
May 20, 2020
…unc, related with issue 34125
jreback
requested changes
Jun 2, 2020
pandas/tests/test_algos.py
Outdated
| @@ -2374,3 +2374,30 @@ def test_index(self): | |||
| dtype="timedelta64[ns]", | |||
| ) | |||
| tm.assert_series_equal(algos.mode(idx), exp) | |||
|
|
|||
| @pytest.mark.xfail(reason="problem related with issue #34125") | |||
There was a problem hiding this comment.
can you put these in the right class, Isin
There was a problem hiding this comment.
Of course, sorry about that, I didn’t realize that this class exists, my bad! But everything looks good now!
Some fix just that i forgot to delete some code
jreback
approved these changes
Jun 8, 2020
|
thanks @gabrielvf1 |
|
So this one just has the tests, but the bug is still present on master? |
Yes, I tried to solve but the way I made it was not right enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff