REF: FY5253Mixin to share methods #34262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
May 20, 2020
| self, n=1, normalize=False, weekday=0, startingMonth=1, variation="nearest" | ||
| ): | ||
| BaseOffset.__init__(self, n, normalize) | ||
| object.__setattr__(self, "startingMonth", startingMonth) |
There was a problem hiding this comment.
question but do we need to reference object here any more or can we not just reference the built in setattr? This is a Py2 compat way of setting things no?
There was a problem hiding this comment.
This is a Py2 compat way of setting things no?
No, it is is compat for a recently-removed def __setattr__ that raised AttributeError to make DateOffsets immutable. We removed that __setattr__ patch because it didnt place nicely with making BaseOffset a cdef class. So we're in a bit of a limbo until we get all of the __init__ methods to be cdef-class-only.
|
thanks! |
PuneethaPai
pushed a commit
to PuneethaPai/pandas
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.