Skip to content

Eliminated the skipna / dropna inconsistency in the docs. #34209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ashwinpn
Copy link
Contributor

@ashwinpn ashwinpn commented May 16, 2020

As @bf mentioned in the comments under the issue #34063 ,
There are errors in the docs for Dataframe.mode, https://pandas.pydata.org/pandasdocs/dev/reference/api/pandas.DataFrame.mode.html (See source : https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L8722-L8807) , where the dropna parameter (which occurs more number of times than skipna) has been named skipna (first occurrence on line 8370).

ashwinpn added 4 commits March 5, 2020 20:48
Was 890 commits behind master - has been sorted now : used the base / master swapping paradigm.
@ashwinpn ashwinpn changed the title Eliminated the skipna / dropna inconsistency in the code. Eliminated the skipna / dropna inconsistency in the docs. May 16, 2020
@ashwinpn ashwinpn marked this pull request as draft May 16, 2020 14:50
@MarcoGorelli
Copy link
Member

Thanks @ashwinpn

Changing all skipnas to dropnas would be a pretty big API change, are you sure it would be worth it?

@ashwinpn
Copy link
Contributor Author

@MarcoGorelli yes, you are correct - That is why I have currently kept this as a draft, it might not be worth it.

@WillAyd
Copy link
Member

WillAyd commented May 19, 2020

Thanks for the PR. In theory I think there are cases where these would signal distinct functionality though there are other functions where they overlap and maybe could be aligned.However, this isn't something we would just change outright - would need to go through a deprecation cycle first for any changes.

I think if something you want to pursue its worth starting with an issue and discussion before a PR. We would need to align further on goal and functions where maybe this makes sense

@WillAyd WillAyd closed this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants