Skip to content

REF: inherit BaseOffset in BusinessMixin #34181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2020
Merged

REF: inherit BaseOffset in BusinessMixin #34181

merged 2 commits into from
May 17, 2020

Conversation

jbrockmendel
Copy link
Member

Cython's cdef classes dont play nicely with multiple inheritance, so we're going to have to turn our mixins into a chain of base classes. This does that for BusinessMixin and BusinessHourMixin, de-duplicating some __init__ methods along the way.

@jbrockmendel jbrockmendel mentioned this pull request May 14, 2020
Merged
@jbrockmendel jbrockmendel added Frequency DateOffsets Refactor Internal refactoring of code labels May 16, 2020
@jreback jreback added this to the 1.1 milestone May 17, 2020
@jreback jreback merged commit d95f125 into pandas-dev:master May 17, 2020
@jbrockmendel jbrockmendel deleted the ref-liboffsets-cbh branch May 17, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Frequency DateOffsets Refactor Internal refactoring of code
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback