TST: Added test for json containing the key "last_status_change_at" #34169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for issue pandas-dev#32409, json containing dicts containing the key last_status_change_at
mroeschke
requested changes
May 14, 2020
There was a problem hiding this comment.
Could you move this test to pandas/tests/frame/methods/test_describe.py?
And structure the test similar to what is describe in our guide?
https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#writing-tests
mroeschke
added
the
Testing
mroeschke
reviewed
May 15, 2020
|
|
||
|
|
||
| def test__unhashable_dict(): | ||
| result = pd.DataFrame( |
There was a problem hiding this comment.
- Could you remove the extra
_intest__ - Could you add the issue number as a comment?
- This test should test this behavior: pandas1.0.1 has trouble with certain column names #32409 (comment)
|
@rivera-fernando can you merge master and respond to comments |
MarcoGorelli
suggested changes
Jun 28, 2020
|
|
||
| def test_unhashable_dict(): | ||
| # GH#32409 | ||
| result = pd.DataFrame( |
There was a problem hiding this comment.
Thanks @rivera-fernando
What's the difference between result and expected? Can you construct result using .describe (as in the original issue)?
|
closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff