REF: separate to_time, avoid runtime imports #34145
Conversation
| @@ -156,7 +159,7 @@ def _maybe_cache(arg, format, cache, convert_listlike): | |||
|
|
|||
| def _box_as_indexlike( | |||
| dt_array: ArrayLike, utc: Optional[bool] = None, name: Optional[str] = None | |||
| ) -> Union[ABCIndex, ABCDatetimeIndex]: | |||
| ) -> Index: | |||
There was a problem hiding this comment.
@simonjayhawkins do we have a way of annotating a return type is either an Index or DatetimeIndex, but no other Index subclass?
There was a problem hiding this comment.
not that i'm aware of. If Index subclasses obey Liskov, shouldn't be an issue. why is this needed?
There was a problem hiding this comment.
why is this needed?
Not "needed", but i guess its a more-specific-is-better thing
| @@ -942,133 +933,3 @@ def calc_with_mask(carg, mask): | |||
| pass | |||
|
|
|||
| return None | |||
|
|
|||
There was a problem hiding this comment.
can you leave to_time here and show a FutureWarning (I know at least ibis is using this)
There was a problem hiding this comment.
updated per request
jreback
added
Clean
Deprecate
| datetime.time | ||
| """ | ||
|
|
||
| def _convert_listlike(arg, format): |
There was a problem hiding this comment.
in followon can make this a module level function
|
can you rebase |
|
rebased+green |
|
|
once more rebase |
| name: Optional[str] = None, | ||
| ) -> ABCIndexClass: | ||
| ) -> "Index": |
There was a problem hiding this comment.
quotes no longer needed?
There was a problem hiding this comment.
good catch. will edit in follow-up
|
thanks! can you edit the deprecations removal issue for this change as well (not sure if you did) |
No description provided.