BUG/ENH: Improve categorical construction when using the iterator in StataReader #34128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
changed the title
bashtage
changed the title
bashtage
force-pushed
the
iterator-cat
branch
4 times, most recently
from
44b73a4 to
51dcc83
Compare
jreback
added
Bug
Categorical
bashtage
force-pushed
the
iterator-cat
branch
2 times, most recently
from
383c122 to
4472717
Compare
jreback
reviewed
May 25, 2020
Return categoricals with the same categories if possible when reading data through an interator. Warn if not possible. closes pandas-dev#31544
Restrict iterator to StataReaders constructed with a positive chunksize
Check the label ordering does not cause any issues
|
thanks @bashtage |
3 tasks
remram44
reviewed
Oct 20, 2020
| if self._chunksize is None: | ||
| raise ValueError( | ||
| "chunksize must be set to a positive integer to use as an iterator." | ||
| ) |
There was a problem hiding this comment.
This breaks when read_stata() is passed iterator=True but no chunksize, #37280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff