TST/REF: Deprivate check_pairwise_moment and remove ConsistencyBase #34119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 11, 2020
| def setup_method(self, method): | ||
| self._create_data() | ||
|
|
||
| def test_ewmcov_pairwise(self): | ||
| self._check_pairwise_moment("ewm", "cov", span=10, min_periods=5) | ||
| check_pairwise_moment(self.frame, "ewm", "cov", span=10, min_periods=5) |
There was a problem hiding this comment.
Could we turn these two test into 1 using pytest.mark.parameterize(func, ['cov', 'corr'])? Think there's similar potential below
There was a problem hiding this comment.
thanks, good catch!
parametrized! also for that two tests in rolling
charlesdong1991
changed the title
mroeschke
added
Testing
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
check_pairwise_momentfunction will be the last function moving out of bigConsistencyBaseclass, and after this,ConsistencyBaseclass only has the_create_datafunction which creates some mock data, so we could entirely removeConsistencyBaseand useBaseinstead.cc @jreback