PERF: use is_foo_dtype fastpaths #34111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/masked.py
Outdated
| dtype = object | ||
| dtype = np.dtype(object) | ||
| else: | ||
| dtype = pandas_dtype(dtype) |
There was a problem hiding this comment.
I don't think we should do this here, as this is converting to a numpy array, the dtype can never be a pandas dtype, and is always meant to be a numpy dtype (so let numpy interpret the string / dtype-like objects)
pandas/core/strings.py
Outdated
| @@ -74,11 +74,11 @@ def cat_core(list_of_columns: List, sep: str): | |||
| """ | |||
| if sep == "": | |||
| # no need to interleave sep if it is empty | |||
| arr_of_cols = np.asarray(list_of_columns, dtype=object) | |||
| arr_of_cols = np.asarray(list_of_columns, dtype=np.dtype(object)) | |||
There was a problem hiding this comment.
You don't need to revert this to be clear, but I also don't think it's needed to change this in numpy functions
There was a problem hiding this comment.
fair enough; i think in this case this was a find-and-replace
|
updated per comments |
jorisvandenbossche
approved these changes
May 11, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.