TST: Mark groupby.nunique test as slow #34096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 9, 2020
dsaxton
changed the title
|
I've also wondered why the parameters are so large. Maybe it'd be worth tracking down the original issue and adding a comment. |
Looks like it was added here: #10894 |
jreback
added
Testing
jreback
approved these changes
May 10, 2020
|
thanks @dsaxton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test takes about 40 seconds to run for me while shrinking the size of the data brings the runtime down to 2 seconds, presumably without changing coverage (do we even need to parametrize over n and m here?).