CLN, TYP: Factor out part of info #34092
Merged
+57
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 10, 2020
| return str(s)[:space].ljust(space) | ||
|
|
||
|
|
||
| def _get_ids_and_dtypes(data: FrameOrSeries) -> Tuple["Index", "Series"]: |
There was a problem hiding this comment.
ok, please add a doc-string
jreback
requested changes
May 10, 2020
|
|
||
| def _put_str(s, space): | ||
|
|
||
| def _put_str(s: Union[str, Dtype], space: int) -> str: |
| return str(s)[:space].ljust(space) | ||
|
|
||
|
|
||
| def _get_ids_and_dtypes(data: FrameOrSeries) -> Tuple["Index", "Series"]: |
There was a problem hiding this comment.
ok, please add a doc-string
jreback
added
Clean
Dtype Conversions
@jreback ping |
jreback
approved these changes
May 11, 2020
|
thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor to #31796, which still has a rather large diff. This should help make it easier to read.
On master,
colsholds the DataFrame's columns. If we were to use this method on a Series, then it would hold an Index containing the Series' name (Index([data.name])). Is there a good name for a variable that could store either? At the moment I've called itids