Skip to content

ENH: make Tick comparisons match Timedelta behavior #34088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 12, 2020
Merged

ENH: make Tick comparisons match Timedelta behavior #34088

merged 10 commits into from
May 12, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jorisvandenbossche
Copy link
Member

Can you indicate if (I assume so, given the title), and if so, what behaviour exactly changed?

@jreback jreback added the Timedelta Timedelta data type label May 9, 2020
@jreback jreback added this to the 1.1 milestone May 9, 2020
@jreback jreback added the Frequency DateOffsets label May 9, 2020
@jbrockmendel
Copy link
Member Author

Can you indicate if (I assume so, given the title), and if so, what behaviour exactly changed?

pd.offsets.Minute(3) < pd.Timedelta(4) will now return False instead of raising TypeError

@jreback
Copy link
Contributor

jreback commented May 10, 2020

looks fine, can you add a whatsnew note

@jbrockmendel
Copy link
Member Author

updated with whatsnew + green

@jreback jreback merged commit d4d21fa into pandas-dev:master May 12, 2020
@jbrockmendel jbrockmendel deleted the td-compare branch May 12, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Frequency DateOffsets Timedelta Timedelta data type
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jorisvandenbossche @jreback