Skip to content

BUG : Series.to_timestamp and Series.to_period raise user-facing AssertionError #34067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 20, 2020
Merged

BUG : Series.to_timestamp and Series.to_period raise user-facing AssertionError #34067

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
80f68b2
resolves series.py issue #33327
May 8, 2020
680318a
Resolved merge conflict by incorporating both suggestions.
May 12, 2020
e2d14cc
added tests for timestamp and period TypError checks
May 12, 2020
ebd4efe
Merge branch 'master' of https://github.com/pandas-dev/pandas into As…
May 12, 2020
2d9c01e
Merge branch 'master' of https://github.com/pandas-dev/pandas into As…
May 20, 2020
08119d2
added tests and doc
May 20, 2020
8d8eb1a
Merge branch 'master' of https://github.com/pandas-dev/pandas into As…
May 20, 2020
4712f13
isort files
May 20, 2020
3e3c775
updating with parameterised index
May 20, 2020
a6eaee0
remove whitespace from doc
May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4661,7 +4661,8 @@ def to_timestamp(self, freq=None, how="start", copy=True) -> "Series":
if copy:
new_values = new_values.copy()

assert isinstance(self.index, (ABCDatetimeIndex, ABCPeriodIndex))
if not isinstance(self.index, (ABCDatetimeIndex, ABCPeriodIndex)):
raise TypeError(f"unsupported Type {self.index}")
new_index = self.index.to_timestamp(freq=freq, how=how)
return self._constructor(new_values, index=new_index).__finalize__(
self, method="to_timestamp"
Expand All @@ -4688,7 +4689,8 @@ def to_period(self, freq=None, copy=True) -> "Series":
if copy:
new_values = new_values.copy()

assert isinstance(self.index, ABCDatetimeIndex)
if not isinstance(self.index, ABCDatetimeIndex):
raise TypeError(f"unsupported Type {self.index}")
new_index = self.index.to_period(freq=freq)
return self._constructor(new_values, index=new_index).__finalize__(
self, method="to_period"
Expand Down