REF: implement ABCTimestamp, ABCTimedelta, ABCTick #34054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
May 7, 2020
| @@ -0,0 +1,20 @@ | |||
| from cpython.datetime cimport datetime, timedelta | |||
|
|
|||
| cdef class ABCTimedelta(timedelta): | |||
There was a problem hiding this comment.
ic, so now we have a cdef class that we can do instance on w/o having to import the world, nice.
jreback
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: to make more progress on getting DateOffset into cython, we need to be able to import Timestamp into liboffsets. ATM that would induce circular dependencies.
This allows us to merge c_timestamp back into timestamps.pyx; the initial motivation for that was to be able to cimport _Timestamp into libconversion.
In a follow-up we can use this pattern to make a faster
is_intervalcheck (that doesnt have to go through python-space)