more informative error message with np.min or np.max on unordered Categorical #34053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Categorical
jbrockmendel
reviewed
May 7, 2020
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -778,6 +778,7 @@ Other | |||
| - Bug in :meth:`DataFrame.__dir__` caused a segfault when using unicode surrogates in a column name (:issue:`25509`) | |||
| - Bug in :meth:`DataFrame.plot.scatter` caused an error when plotting variable marker sizes (:issue:`32904`) | |||
| - :class:`IntegerArray` now implements the ``sum`` operation (:issue:`33172`) | |||
| - more informative error message with ``np.min`` or ``np.max`` on unordered Categorical (:issue:`33115`) | |||
There was a problem hiding this comment.
Capitalize "more", ":class:`Categorical`"
topper-123
requested changes
May 7, 2020
topper-123
approved these changes
May 16, 2020
|
I think all comments addressed. will merge tomorrow if no further comments. |
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
May 19, 2020
…message with np.min or np.max on unordered Categorical)
simonjayhawkins
added a commit
that referenced
this pull request
May 19, 2020
…th np.min or np.max on unordered Categorical) (#34246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff