-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Bug in Series.groupby would raise ValueError when grouping by PeriodIndex level #34049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
simonjayhawkins
merged 8 commits into
pandas-dev:master
from
simonjayhawkins:period-regression
May 19, 2020
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
857e576
Revert part "CLN: Catch more specific exceptions in groupby
simonjayhawkins 086cb47
add test for 34010
simonjayhawkins f3c16fc
add ValueError to caught exceptions
simonjayhawkins 0f5fb58
whatsnew
simonjayhawkins 0afc3b4
Merge remote-tracking branch 'upstream/master' into period-regression
simonjayhawkins af642d3
add backticks to release note
simonjayhawkins b5f4dfd
update whatsnew
simonjayhawkins effc7c5
Merge remote-tracking branch 'upstream/master' into period-regression
simonjayhawkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1307,6 +1307,14 @@ def test_size_groupby_all_null(): | |
tm.assert_series_equal(result, expected) | ||
|
||
|
||
def test_size_period_index(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you move this to the new test_size.py file |
||
# https://github.com/pandas-dev/pandas/issues/34010 | ||
ser = Series([1], index=pd.PeriodIndex(["2000"], name="A", freq="D")) | ||
grp = ser.groupby(level="A") | ||
result = grp.size() | ||
tm.assert_series_equal(result, ser) | ||
|
||
|
||
# quantile | ||
# -------------------------------- | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use double backticks on ValueError and PeriodIndex