PERF: use isinstance(obj, Foo) instead of ABCFoo #34040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
approved these changes
May 7, 2020
simonjayhawkins
approved these changes
May 8, 2020
pandas/core/frame.py
Outdated
| @@ -7020,8 +7014,8 @@ def _gotitem( | |||
| self, | |||
| key: Union[str, List[str]], | |||
| ndim: int, | |||
| subset: Optional[Union[Series, ABCDataFrame]] = None, | |||
| ) -> Union[Series, ABCDataFrame]: | |||
| subset: Optional[Union[Series, "DataFrame"]] = None, | |||
There was a problem hiding this comment.
_typing.FrameOrSeriesUnion or _typing.FrameOrSeries?
pandas/core/frame.py
Outdated
| subset: Optional[Union[Series, ABCDataFrame]] = None, | ||
| ) -> Union[Series, ABCDataFrame]: | ||
| subset: Optional[Union[Series, "DataFrame"]] = None, | ||
| ) -> Union[Series, "DataFrame"]: |
|
Thanks! |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per discussion in #27353, isinstance checks with the ABCFoo are about 4x as expensive as the Foo checks. Individually they are still very small, but they add up.