Skip to content

CLN: spelling fixes in docstrings #34039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2020

Conversation

akosfurton
Copy link
Contributor

@akosfurton akosfurton commented May 6, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some doctest failures with your changes

@akosfurton
Copy link
Contributor Author

Appears that TestHDFStore.test_append_with_data_columns is failing in 1 of the 5 TravisCI builds.

I didn't change that function, and it looks to have passed in all other Azure pipeline builds. Is this a known flaky test?

@simonjayhawkins
Copy link
Member

Is this a known flaky test?

yes.

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone May 8, 2020
@mroeschke mroeschke merged commit 6388370 into pandas-dev:master May 8, 2020
@mroeschke
Copy link
Member

Thanks @akosfurton! The failing Travis build was unrelated test failure

jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request May 8, 2020
* spelling fixes

* add whatsnew entry

* fix doctests

* and one more that wasn't caught
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
* spelling fixes

* add whatsnew entry

* fix doctests

* and one more that wasn't caught
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants