CLN: Use to_numpy directly in cov / corr #34031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this can raise for an all integer DataFrame without any missing values
Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
WillAyd
approved these changes
May 20, 2020
jreback
reviewed
May 20, 2020
pandas/core/frame.py
Outdated
| @@ -7973,7 +7973,7 @@ def corr(self, method="pearson", min_periods=1) -> "DataFrame": | |||
| numeric_df = self._get_numeric_data() | |||
| cols = numeric_df.columns | |||
| idx = cols.copy() | |||
| mat = numeric_df.astype(float, copy=False).to_numpy() | |||
| mat = numeric_df.to_numpy(dtype=float, na_value=np.nan) | |||
There was a problem hiding this comment.
do we have copy=False by default in .to_numpy()?
There was a problem hiding this comment.
Yes but I can make this explicit
jorisvandenbossche
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.