Skip to content

CLN: avoid getattr checks in liboffsets #34008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2020
Merged

CLN: avoid getattr checks in liboffsets #34008

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d28035
avoid hasattr checks in liboffsets
jbrockmendel May 5, 2020
3bca391
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel May 5, 2020
fab0b03
dummy commit to force CI
jbrockmendel May 5, 2020
b8863a5
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions pandas/_libs/tslibs/offsets.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ from pandas._libs.tslibs.np_datetime cimport (
npy_datetimestruct, dtstruct_to_dt64, dt64_to_dtstruct)
from pandas._libs.tslibs.timezones import UTC
from pandas._libs.tslibs.tzconversion cimport tz_convert_single
from pandas._libs.tslibs.c_timestamp cimport _Timestamp


# ---------------------------------------------------------------------
Expand Down Expand Up @@ -105,17 +106,18 @@ cdef to_offset(object obj):
return to_offset(obj)


def as_datetime(obj):
f = getattr(obj, 'to_pydatetime', None)
if f is not None:
obj = f()
def as_datetime(obj: datetime) -> datetime:
if isinstance(obj, _Timestamp):
return obj.to_pydatetime()
return obj


cpdef bint is_normalized(dt):
if (dt.hour != 0 or dt.minute != 0 or dt.second != 0 or
dt.microsecond != 0 or getattr(dt, 'nanosecond', 0) != 0):
cpdef bint is_normalized(datetime dt):
if dt.hour != 0 or dt.minute != 0 or dt.second != 0 or dt.microsecond != 0:
# Regardless of whether dt is datetime vs Timestamp
return False
if isinstance(dt, _Timestamp):
return dt.nanosecond == 0
return True


Expand Down