-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix Series.update ExtensionArray issue #33984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. there is a release note conflict. can you merge master and ping on green.
@jreback ping |
thanks @dsaxton |
hmm, the tests added here fail when backporting this fix. There have been many refactors of the indexing code since 1.0.3 |
removing the needs backport label for now. |
@simonjayhawkins generally in backport i would do the least possible ones to avoid new issues |
this PR did fix a regression #34020 (comment) so was a candidate for backport. |
i understand but my point is that we only want backport a very minutes number of tegressions - esp later in a release series |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff