Skip to content

BUG: Fix Series.update ExtensionArray issue #33984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2020
Merged

BUG: Fix Series.update ExtensionArray issue #33984

merged 2 commits into from
May 5, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented May 5, 2020

@jorisvandenbossche jorisvandenbossche added Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays labels May 5, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone May 5, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. there is a release note conflict. can you merge master and ping on green.

@dsaxton
Copy link
Member Author

dsaxton commented May 5, 2020

@jreback ping

@jreback jreback merged commit e1ee2b0 into pandas-dev:master May 5, 2020
@jreback
Copy link
Contributor

jreback commented May 5, 2020

thanks @dsaxton

@dsaxton dsaxton deleted the extension-array-update branch May 5, 2020 20:30
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request May 6, 2020
@simonjayhawkins
Copy link
Member

hmm, the tests added here fail when backporting this fix. There have been many refactors of the indexing code since 1.0.3

@simonjayhawkins
Copy link
Member

hmm, the tests added here fail when backporting this fix. There have been many refactors of the indexing code since 1.0.3

removing the needs backport label for now.

@jreback
Copy link
Contributor

jreback commented May 30, 2020

@simonjayhawkins generally in backport i would do the least possible ones to avoid new issues

@simonjayhawkins
Copy link
Member

this PR did fix a regression #34020 (comment)

so was a candidate for backport.

@jreback
Copy link
Contributor

jreback commented May 30, 2020

i understand but my point is that we only want backport a very minutes number of tegressions - esp later in a release series

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.update() raises ValueError if dtype="string"
4 participants