BUG: Use args and kwargs in Rolling.apply #33983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 5, 2020
mroeschke
reviewed
May 5, 2020
jreback
requested changes
May 5, 2020
simonjayhawkins
requested changes
May 8, 2020
jreback
requested changes
May 8, 2020
|
Hello @mproszewska! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-05-15 11:38:03 UTC |
mproszewska
changed the title
mroeschke
reviewed
May 11, 2020
mroeschke
reviewed
May 11, 2020
pandas/tests/window/test_apply.py
Outdated
| idx = Index(["gr", "a"]) | ||
| expected = DataFrame([[11.0, 11.0], [11.0, 12.0]], columns=idx) | ||
|
|
||
| result = df.rolling(1).apply(foo, kwargs={"par": 10}) |
There was a problem hiding this comment.
Could you parameterize over the kwargs & args?
pytest.mark.parameterize('args_kwargs', [[None, {"par": 10}], [(10,), None]])
jreback
approved these changes
May 15, 2020
|
thanks @mproszewska cc @simonjayhawkins marked for 1.04 as well |
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
May 15, 2020
…s in Rolling.apply)
simonjayhawkins
added a commit
that referenced
this pull request
May 15, 2020
…ng.apply) (#34190) Co-authored-by: mproszewska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kwargsinRolling.apply()#33433black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff