REF: simplify Timedelta arithmetic methods #33978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 4, 2020
| # Series, DataFrame, ... | ||
| if other._typ == 'dateoffset' and hasattr(other, 'delta'): | ||
| # Tick offset; this op will raise TypeError | ||
| return other.delta * self |
There was a problem hiding this comment.
This part is covered by rmul of DateOffset?
There was a problem hiding this comment.
It will go through DateOffset.__rmul__ which will raise TypeError (correctly), yes.
| # i.e. np.nan, but also catch np.float64("NaN") which would | ||
| # otherwise get caught by the hasattr(other, "dtype") branch | ||
| # incorrectly return a np.timedelta64 object. | ||
| return NaT |
There was a problem hiding this comment.
not checking this, does that give a change in behaviour?
There was a problem hiding this comment.
the util.is_nan case is subsumed by the is_float_object case on L1351
| # i.e. np.nan, but also catch np.float64("NaN") which would | ||
| # otherwise get caught by the hasattr(other, "dtype") branch | ||
| # incorrectly return a np.timedelta64 object. | ||
| return NaT |
There was a problem hiding this comment.
same here, subsumed by the is_float_object case on L1370
|
de facto green as of 3 hours ago, Travis icon hasnt updated |
jorisvandenbossche
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this avoids the "_typ" checks which go through python-space