-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: update conf.py to use new numpy doc url #33954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @codeloop, did you build the docs locally and checked that the link is working all right? I guess the intersphinx file is available at the new URL, but we need to make sure before merging this. Thanks! |
@datapythonista , I'm building the docs, following the steps from here Contributing to the documentation, will update after build is complete & tested locally. |
successfully built documentation locally using this commit, now the links point to numpy URL. Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @codeloop, lgtm
@jorisvandenbossche may be you want to have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
@meeseeksdev backport to 1.0.x |
) Co-authored-by: Vikas Pandey <[email protected]>
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff