Skip to content

DOC: update conf.py to use new numpy doc url #33954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020

Conversation

codeloop
Copy link
Contributor

@codeloop codeloop commented May 3, 2020

@datapythonista
Copy link
Member

Thanks @codeloop, did you build the docs locally and checked that the link is working all right? I guess the intersphinx file is available at the new URL, but we need to make sure before merging this. Thanks!

@jreback jreback added this to the 1.1 milestone May 4, 2020
@codeloop
Copy link
Contributor Author

codeloop commented May 4, 2020

@datapythonista , I'm building the docs, following the steps from here Contributing to the documentation, will update after build is complete & tested locally.

@codeloop
Copy link
Contributor Author

codeloop commented May 5, 2020

successfully built documentation locally using this commit, now the links point to numpy URL.
For eg: In the pandas docs at https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.argsort.html
earlier it was referencing to : https://docs.scipy.org/doc/numpy/reference/generated/numpy.ndarray.argsort.html#numpy.ndarray.argsort
After this commit & build it references to : https://numpy.org/doc/stable/reference/generated/numpy.ndarray.argsort.html#numpy.ndarray.argsort

Looks good to me.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @codeloop, lgtm

@datapythonista
Copy link
Member

@jorisvandenbossche may be you want to have a look

@jorisvandenbossche jorisvandenbossche changed the title updated conf.py to use numpy website url #33953 DOC: update conf.py to use new numpy doc url May 5, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@jorisvandenbossche jorisvandenbossche merged commit 8c5d0cd into pandas-dev:master May 5, 2020
@jorisvandenbossche jorisvandenbossche modified the milestones: 1.1, 1.0.4 May 5, 2020
@simonjayhawkins
Copy link
Member

@meeseeksdev backport to 1.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Update numpy website url
5 participants