TST: add pattern for nearest #33939
Merged
TST: add pattern for nearest #33939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotamatsuoka
changed the title
alimcmaster1
added
the
Testing
jreback
requested changes
May 2, 2020
| @@ -535,11 +535,13 @@ def test_upsample_with_limit(): | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_nearest_upsample_with_limit(): | |||
| rng = date_range("1/1/2000", periods=3, freq="5t") | |||
| @pytest.mark.parametrize("freq", ["Y", "10M", "5D", "10H", "5Min", "10S"]) | |||
There was a problem hiding this comment.
you need to add the tz_aware_fixture here as well
There was a problem hiding this comment.
Thanks @jreback. I've done.
kotamatsuoka
force-pushed
the
add-datetime-resample-tests
branch
from
9c0b287 to
e9be06b
Compare
mroeschke
reviewed
May 3, 2020
kotamatsuoka
force-pushed
the
add-datetime-resample-tests
branch
from
7f0339f to
a357330
Compare
mroeschke
approved these changes
May 4, 2020
jreback
approved these changes
May 6, 2020
|
thanks @kotamatsuoka |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff