REF: implement _unbox to de-duplicate unwrapping #33906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Apr 30, 2020
pandas/core/arrays/datetimelike.py
Outdated
| @@ -52,6 +52,8 @@ | |||
| from pandas.tseries import frequencies | |||
| from pandas.tseries.offsets import DateOffset, Tick | |||
|
|
|||
| DTScalar = Union[Period, Timestamp, Timedelta, NaTType] | |||
There was a problem hiding this comment.
would put in _typing and call it DatetimeScalar
There was a problem hiding this comment.
Actually looks like we already have DatetimeLikeScalar which just needs to have NaTType added to it
jreback
reviewed
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately we want these _validate_foo methods to be whittled down to only one or two methods.