CI: troubleshoot CI #33898
Merged
CI: troubleshoot CI #33898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Apr 30, 2020
| @@ -1390,10 +1390,14 @@ def test_constructor_cast_object(self, index): | |||
| tm.assert_series_equal(s, exp) | |||
|
|
|||
| @pytest.mark.parametrize("dtype", [np.datetime64, np.timedelta64]) | |||
| def test_constructor_generic_timestamp_no_frequency(self, dtype): | |||
| def test_constructor_generic_timestamp_no_frequency(self, dtype, request): | |||
There was a problem hiding this comment.
Is this just an alternative to an imperative call that would fail if the test doesn't produce an expected failure?
There was a problem hiding this comment.
nice. more verbose but probably a better general solution
WillAyd
approved these changes
Apr 30, 2020
5 tasks
|
sure |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.