-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Series construction with EA dtype and index but no data fails #33846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
simonjayhawkins
merged 29 commits into
pandas-dev:master
from
simonjayhawkins:broadcast-ea-bug
May 2, 2020
Merged
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
a06e1a4
BUG: Series construction with EA dtype and index but no data fails
simonjayhawkins 6ae3342
redo tests
simonjayhawkins 72f8ec3
Merge remote-tracking branch 'upstream/master' into broadcast-ea-bug
simonjayhawkins 7a17b33
Merge remote-tracking branch 'upstream/master' into broadcast-ea-bug
simonjayhawkins 1881a03
add test_series_constructor_scalar_with_one_element_index
simonjayhawkins 45ef9a5
move dtype to test function parameters
simonjayhawkins a339f05
comment - whatsnew
simonjayhawkins 6bfbd1a
comment - merge tests
simonjayhawkins 1c8bd8c
special case to avoid _try_cast call
simonjayhawkins 840df49
troubleshoot
simonjayhawkins 9cf81ee
less failures
simonjayhawkins d427714
maybe_cast_to_datetime
simonjayhawkins d47cba4
add failure reason for pyarrow
simonjayhawkins c5cc30d
update issue ref for ArrowBoolDtype
simonjayhawkins 421aa7c
remove sparse test overrides
simonjayhawkins 4c51356
ref to new issue for JSONDtype RecursionError
simonjayhawkins ff4ff63
collection as scalar msg and gh ref
simonjayhawkins aa11bb6
Merge remote-tracking branch 'upstream/master' into broadcast-ea-bug
simonjayhawkins 268f3a5
fix corner case
simonjayhawkins 2df2bf1
comment - maybe_cast_to_datetime
simonjayhawkins 211328c
Merge remote-tracking branch 'upstream/master' into broadcast-ea-bug
simonjayhawkins e598f4c
add test for gh-33559
simonjayhawkins 8c44e23
troubleshoot timeout
simonjayhawkins dac66d0
troubleshoot timeout
simonjayhawkins b363fb2
Merge remote-tracking branch 'upstream/master' into broadcast-ea-bug
simonjayhawkins f2026d3
troubleshoot timeout
simonjayhawkins 52fcd7f
skip on py3.6
simonjayhawkins 4907f34
Merge remote-tracking branch 'upstream/master' into broadcast-ea-bug
simonjayhawkins 663c863
Merge branch 'master' into broadcast-ea-bug
jreback File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,6 +151,11 @@ def test_array_from_scalars(self, data): | |
# ValueError: PandasArray must be 1-dimensional. | ||
super().test_array_from_scalars(data) | ||
|
||
@skip_nested | ||
def test_series_constructor_scalar_with_index(self, data, dtype): | ||
# ValueError: Length of passed values is 1, index implies 3. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for the object dtype, the scalar is a tuple, so this failure is related to #33846 (comment) |
||
super().test_series_constructor_scalar_with_index(data, dtype) | ||
|
||
|
||
class TestDtype(BaseNumPyTests, base.BaseDtypeTests): | ||
@pytest.mark.skip(reason="Incorrect expected.") | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR appears to also close #33559
the index discrepancy is consistent with non-EA types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is another PR trying to clean this up