TST: Clean moments consistency #33813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimcmaster1
added
the
Testing
|
great looks good. when doing these types of reactoring just make sure that we don't lose tests (a bit tricky to check here as you are actually changing the number of tests), but lgtm. |
|
thanks @charlesdong1991 |
|
thanks @jreback i will keep followups smaller, and easier to check if any test is lost! |
jbrockmendel
reviewed
May 3, 2020
| @@ -418,3 +404,44 @@ def test_expanding_consistency(self, min_periods): | |||
| # GH 9422 | |||
| if name in ["sum", "prod"]: | |||
| tm.assert_equal(expanding_f_result, expanding_apply_f_result) | |||
|
|
|||
| @pytest.mark.parametrize("min_periods", [0, 1, 2, 3, 4]) | |||
There was a problem hiding this comment.
should these get @pytest.mark.slow? test_rolling_consistency_cov clocks in at 38 seconds for me
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #30577 (comment)
This PR is the first step to achieve it, it basically does one thing: break up the giant consistency test in
commoninto four tests based on test contents:var,std,cov, andseries data.cc @jreback