-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Add warning if rows have more columns than expected #33782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
b042377
Add warnings when rows in csv file have too many values
mproszewska 89a04c5
Remove unused variable
mproszewska 23c9109
Add helper function
mproszewska 77537c2
Add comma in test
mproszewska 5c0dfb4
Merge branch 'master' into csv
mproszewska 9bb7a86
Include index_col and usecols in check
mproszewska 2d661e8
Run black
mproszewska 61d66ab
Add docstring
mproszewska c94b45e
PERF: Remove unnecessary copies in sorting functions
mproszewska 0ab450b
Run tests
mproszewska 54c7304
Run tests
mproszewska e00993d
Move function
mproszewska 6d72a34
Add asv
mproszewska 5ba54a6
Run black
mproszewska 2766270
Remove asv
mproszewska 91176ca
Merge branch 'perf'
mproszewska 412cd45
Run tests
mproszewska f748b78
Merge remote-tracking branch 'upstream/master'
mproszewska c04c494
Merge remote-tracking branch 'upstream/master'
mproszewska f1807ee
Merge branch 'master' into csv
mproszewska 4d7c568
Remove newline
mproszewska bbe77ca
Fix
mproszewska d9aa319
Add asv
mproszewska 0afb1b1
Fix
mproszewska 35539d0
Add warnings when rows in csv file have too many values
mproszewska 358113b
Remove unused variable
mproszewska ab22429
Add helper function
mproszewska 996213d
Add comma in test
mproszewska 17d9b12
Include index_col and usecols in check
mproszewska 44a5da5
Run black
mproszewska c191274
Add docstring
mproszewska 0567294
Move function
mproszewska 31c9bd0
Run tests
mproszewska 9a84498
Remove newline
mproszewska 459250b
Fix
mproszewska cd0ad9e
Merge branch 'csv' of https://github.com/mproszewska/pandas into csv
mproszewska cd1239f
Resolve conflicts
mproszewska 6ad230a
Merge branch 'master' into csv
mproszewska 18f3767
Run black
mproszewska File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need the
notna
check?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In example mentioned in linked issue additional comma was added in one row. I assumed that additional commas are common and hence we might ignore them and don't raise a warning.
I'm using notna to check if data that won't be included contains only NaN values.