CLN: avoid getattr(obj, "values", obj) #33776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Apr 24, 2020
|
LGTM as well. Clearer call IMO |
mroeschke
approved these changes
Apr 25, 2020
jorisvandenbossche
requested changes
Apr 25, 2020
pandas/core/arrays/interval.py
Outdated
| @@ -648,7 +648,7 @@ def fillna(self, value=None, method=None, limit=None): | |||
| ) | |||
| raise TypeError(msg) | |||
|
|
|||
| value = getattr(value, "_values", value) | |||
| value = extract_array(value, extract_numpy=True) | |||
There was a problem hiding this comment.
There is a if not isinstance(value, Interval) just above, meaning that value should be an Interval, and this line can just be removed altogether?
There was a problem hiding this comment.
good catch, will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #27167
@mroeschke can you pls double-check me on the change in window.rolling