[#33770] bug fix to prevent ExtensionArrays from crashing Series.__repr__() #33771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 24, 2020
jreback
added
Bug
ExtensionArray
|
Thanks for the prompt review! I've pushed some updates to this branch which should hopefully address the review comments. |
jreback
approved these changes
May 1, 2020
|
lgtm. running CI now. merge on green. |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis pull request fixes a bug in
GenericArrayFormatterthat caused a crash when rendering arrays of arrays. This problem causesSeries.__repr__()to fail with certain extension types; see #33770 for more information.The root cause is this line:
The call to
notna()here returns a 2D array ifvalsis a 2D array, whilelib.map_infer(vals, is_float)returns a 1D array ifvalsis a 2D array.In addition to fixing that line, this PR also adds tests for the issue.