CLN: Remove is_null_period #33750
Merged
CLN: Remove is_null_period #33750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,7 @@ cpdef bint checknull(object val): | |||
| - NaT | |||
| - np.datetime64 representation of NaT | |||
| - np.timedelta64 representation of NaT | |||
| - NA | |||
There was a problem hiding this comment.
this is an unrelated cleanup?
There was a problem hiding this comment.
Yeah I just noticed that was missing from the docstring so added it here
|
LGTM |
jorisvandenbossche
approved these changes
Apr 23, 2020
|
Thanks! |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_null_period seems only to be an alias for checknull_with_nat so I think it can be removed?